remove virtual from the add_measurement method (backport #2558) - #2562
Merged
Conversation
(cherry picked from commit 0a12421)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jazzy #2562 +/- ##
==========================================
+ Coverage 89.01% 89.06% +0.04%
==========================================
Files 145 145
Lines 16535 16534 -1
Branches 1396 1396
==========================================
+ Hits 14719 14726 +7
+ Misses 1283 1277 -6
+ Partials 533 531 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2556
I don't think the method needs to be virtual, and with this change the warnings shouldn't appear anymore.
This is an automatic backport of pull request #2558 done by Mergify.