Skip to content

remove virtual from the add_measurement method (backport #2558) - #2562

Merged
christophfroehlich merged 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-2558
Sep 18, 2025
Merged

remove virtual from the add_measurement method (backport #2558)#2562
christophfroehlich merged 1 commit into
jazzyfrom
mergify/bp/jazzy/pr-2558

Conversation

@mergify

@mergify mergify Bot commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Fixes: #2556

I don't think the method needs to be virtual, and with this change the warnings shouldn't appear anymore.


This is an automatic backport of pull request #2558 done by Mergify.

@christophfroehlich
christophfroehlich merged commit 2e94a32 into jazzy Sep 18, 2025
12 of 14 checks passed
@christophfroehlich
christophfroehlich deleted the mergify/bp/jazzy/pr-2558 branch September 18, 2025 16:01
@codecov

codecov Bot commented Sep 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.06%. Comparing base (638ea8e) to head (d032a4d).
⚠️ Report is 3 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2562      +/-   ##
==========================================
+ Coverage   89.01%   89.06%   +0.04%     
==========================================
  Files         145      145              
  Lines       16535    16534       -1     
  Branches     1396     1396              
==========================================
+ Hits        14719    14726       +7     
+ Misses       1283     1277       -6     
+ Partials      533      531       -2     
Flag Coverage Δ
unittests 89.06% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lude/hardware_interface/types/statistics_types.hpp 96.62% <100.00%> (+1.12%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants