Skip to content

Fix the CPU affinity of the ros2_control_node (#2509)#2809

Closed
bjin2364 wants to merge 2 commits into
ros-controls:humblefrom
bjin2364:cherry_pick_thread_affinity
Closed

Fix the CPU affinity of the ros2_control_node (#2509)#2809
bjin2364 wants to merge 2 commits into
ros-controls:humblefrom
bjin2364:cherry_pick_thread_affinity

Conversation

@bjin2364

Copy link
Copy Markdown

Changes

  • Moves the thread affinity settings into control loop thread. This is a cherry-pick of @saikishor's commit to humble
    (cherry picked from commit 94e610a)

@mergify

mergify Bot commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

@bjin2364, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.65%. Comparing base (ce21931) to head (6ea0d67).
⚠️ Report is 2 commits behind head on humble.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 8.33% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2809      +/-   ##
==========================================
- Coverage   63.67%   63.65%   -0.03%     
==========================================
  Files         116      116              
  Lines       12442    12449       +7     
  Branches     8668     8673       +5     
==========================================
+ Hits         7923     7924       +1     
- Misses        759      764       +5     
- Partials     3760     3761       +1     
Flag Coverage Δ
unittests 63.65% <8.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 55.76% <8.33%> (-10.90%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich

Copy link
Copy Markdown
Member

can't we just backport #2509?

@bjin2364

Copy link
Copy Markdown
Author

@christophfroehlich I'm not familiar with the backport process. How does that work?

@christophfroehlich

Copy link
Copy Markdown
Member

maintainers can trigger that manually

@christophfroehlich

Copy link
Copy Markdown
Member

#2823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants