Make sleep in ros2_control node optional (backport #3213)#3452
Merged
Conversation
(cherry picked from commit 2296fd8) # Conflicts: # controller_manager/CMakeLists.txt
Contributor
Author
|
Cherry-pick of 2296fd8 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Removed gmock test for controller manager with resource manager.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jazzy #3452 +/- ##
==========================================
+ Coverage 89.43% 89.49% +0.06%
==========================================
Files 161 163 +2
Lines 20568 20651 +83
Branches 1630 1633 +3
==========================================
+ Hits 18395 18482 +87
+ Misses 1502 1498 -4
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fmauch
approved these changes
Jul 10, 2026
fmauch
left a comment
Contributor
There was a problem hiding this comment.
Just tested this with UniversalRobots/Universal_Robots_ROS2_Driver#1760 and works as expected :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR makes the sleep that paces the controller manager loop optional. This can be useful in situations where
I am aware, that this would only cover a subset of all applications facing this issue. I was holding this back because of the efforts made in ros-controls/realtime_tools#478 but since this will require more designing, I wanted to propose this simple fix for simple systems at least.
Did you use Generative AI?
I had help from Cursor to generate the tests, specifically commit 296ae28
Additional Information
I've implemented a PoC using this with the ur_robot_driver in UniversalRobots/Universal_Robots_ROS2_Driver#1760. There, I also describe the impact on joint control that this would have.
TODOs
This is a draft PR for now, as a couple of things aren't finalized, yet. However, I would like some input on the first two points on the list below.
This is an automatic backport of pull request #3213 done by [Mergify](https://mergify.com).