Skip to content

rqt_cm: Robustify test and fix shutdown races (backport #3396)#3464

Merged
christophfroehlich merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-3396
Jul 14, 2026
Merged

rqt_cm: Robustify test and fix shutdown races (backport #3396)#3464
christophfroehlich merged 2 commits into
jazzyfrom
mergify/bp/jazzy/pr-3396

Conversation

@mergify

@mergify mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes several shutdown races

Closes ros-controls/ros2_control_ci#840, closes ros-controls/ros2_control_ci#841, closes ros-controls/ros2_control_ci#842, closes ros-controls/ros2_control_ci#843, closes ros-controls/ros2_control_ci#844 closes ros-controls/ros2_control_ci#847 closes ros-controls/ros2_control_ci#846

Is this user-facing behavior change?

no

Did you use Generative AI?

GPT-5.3-Codex


This is an automatic backport of pull request #3396 done by Mergify.

(cherry picked from commit 427cb38)

# Conflicts:
#	rqt_controller_manager/test/test_run_launch.py
@mergify mergify Bot added the conflicts label Jul 13, 2026
@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Cherry-pick of 427cb38 has failed:

On branch mergify/bp/jazzy/pr-3396
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit 427cb38.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rqt_controller_manager/rqt_controller_manager/controller_manager.py

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   rqt_controller_manager/test/test_run_launch.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.51%. Comparing base (6dbcd10) to head (0082288).

Additional details and impacted files
@@           Coverage Diff           @@
##            jazzy    #3464   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         163      163           
  Lines       20651    20651           
  Branches     1633     1633           
=======================================
  Hits        18485    18485           
  Misses       1494     1494           
  Partials      672      672           
Flag Coverage Δ
unittests 89.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 420abbf into jazzy Jul 14, 2026
14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-3396 branch July 14, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant