Skip to content

Add autocenter#308

Open
chrisbitter wants to merge 10 commits into
ros-drivers:ros2from
enabl-tech:add_autocenter
Open

Add autocenter#308
chrisbitter wants to merge 10 commits into
ros-drivers:ros2from
enabl-tech:add_autocenter

Conversation

@chrisbitter

@chrisbitter chrisbitter commented Dec 12, 2025

Copy link
Copy Markdown

Adding a parameter to use autocentering.

Tested on a Logitech G920.

@Nils-ChristianIseke

Copy link
Copy Markdown

Hi @clalancette and @JWhitleyWork,

If you think this makes sense for the project, we’d love to see it merged when you have time.
These changes cover what we need on our side and would help us stay aligned with upstream rather than maintaining a fork.

We’d really appreciate a PR review whenever it fits your schedule — happy to address any feedback or make adjustments.

Thanks a lot for your work and for maintaining this project!

Comment thread joy/src/joy.cpp Outdated
Comment thread joy/src/joy.cpp Outdated
Comment thread joy/README.md Outdated
@peci1

peci1 commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR.

I'm not yet 100% sure about the ABI breakage policy of this package, but normally, adding a class member to a public header means breaking ABI, which would mean this change could only be merged to Rolling. If you needed it to work in older ROS distros, some of the hacks for keeping ABI stable would have to be applied. Do you need this change in some of the stable distros?

@peci1 peci1 self-assigned this Feb 15, 2026
chrisbitter and others added 4 commits February 24, 2026 10:12
Co-authored-by: Martin Pecka <peci1@seznam.cz>
Co-authored-by: Martin Pecka <peci1@seznam.cz>
@chrisbitter

Copy link
Copy Markdown
Author

Thanks for the review @peci1 :) I fixed the code accordingly. Also tested again on our Logitech G920.

We are running on Jazzy. Also happy to help implementing the "hacks" if necessary.
Whats your proposed way forward? Shall we merge this PR and address the backward compatibility as a new issue?

@peci1

peci1 commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for iterating. I tested the change and it needs some rework (which I did in enabl-tech#2 ). Would you please test my change and accept that PR towards your repo (which will then update this PR with my proposed changes).

peci1 and others added 2 commits March 7, 2026 23:07
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
fix(joy): Moved autocenter setting to joystick init
@chrisbitter

Copy link
Copy Markdown
Author

Great, thanks! Tested and merged in our repo.

@chrisbitter chrisbitter requested a review from peci1 April 27, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants