Humble support and removal of undesired transformation between y and z axis#82
Open
Gerjen100 wants to merge 2 commits intoros-drivers:foxy-develfrom
Open
Humble support and removal of undesired transformation between y and z axis#82Gerjen100 wants to merge 2 commits intoros-drivers:foxy-develfrom
Gerjen100 wants to merge 2 commits intoros-drivers:foxy-develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qos got added in ROS humble as a default parameter. This is not caught during launch by the mocap node and causes the program to always crash in humble. I didnt implement QOS parameters but just added catch exceptions for possible further work. I also removed an unnecessary flip between y and z as already removed before by @321thijs123 but was re-added for no apparent reason in a later commit.