Introduce points_reached to ReachResultSummary#87
Open
Danilrivero wants to merge 1 commit intoros-industrial:masterfrom
Open
Introduce points_reached to ReachResultSummary#87Danilrivero wants to merge 1 commit intoros-industrial:masterfrom
Danilrivero wants to merge 1 commit intoros-industrial:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #33 in our use case we required a preset of points by generating the pcd without a mesh.
In this case knowing the amount of points for which a solution has been generated was useful to understand the ideal configuration of the robot.
Probably the use case is out of scope in relation to the main focus of the package (work with meshes in which the amount of points reached does not represent an useful information) so it may not be something ideal to merge. Leaving this PR here in case it is interesting to merge or for anyone.
Cheers.