Add invalid data checks to the Geometry data#242
Open
saikishor wants to merge 8 commits intoros:rollingfrom
Open
Add invalid data checks to the Geometry data#242saikishor wants to merge 8 commits intoros:rollingfrom
saikishor wants to merge 8 commits intoros:rollingfrom
Conversation
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
scpeters
reviewed
Apr 9, 2026
| return false; | ||
| } | ||
|
|
||
| if (!std::isfinite(s.radius) || s.radius <= 0) |
Contributor
There was a problem hiding this comment.
can you add version checks so these only take effect for version 1.2 and greater? similar to the effort and velocity limit checks added in #212
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@scpeters I've separated the checks, so it can be added for the rolling distro alone
Continuation of #238