Open
Conversation
saikishor
force-pushed
the
update/headers_to_hpp
branch
from
c9899fc to
c544628
Compare
Contributor
Author
|
Even though it appears as if I haven't moved the file, I think it is a github artifact, but the original file does retain the git history 
|
ahcorde
requested changes
Apr 7, 2026
saikishor
force-pushed
the
update/headers_to_hpp
branch
2 times, most recently
from
517d7ca to
d6fd969
Compare
ahcorde
requested changes
Apr 7, 2026
saikishor
force-pushed
the
update/headers_to_hpp
branch
from
a28b4eb to
9c457ad
Compare
ahcorde
requested changes
Apr 7, 2026
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
do you mind to fix the conflicts?
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor
force-pushed
the
update/headers_to_hpp
branch
from
9c457ad to
4acac84
Compare
Contributor
Author
Done! |
Contributor
Author
|
@ahcorde Should I add deprecation warnings here as well? |
Contributor
yes, please |
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
ahcorde
approved these changes
Apr 9, 2026
Contributor
|
Pulls: #250, ros/urdfdom_headers#100
|
saikishor
commented
Apr 9, 2026
Comment on lines
+43
to
+45
| #pragma message("warning: urdfdom/exportdecl.h is deprecated. Please use urdfdom/exportdecl.hpp instead.") | ||
| #else | ||
| #warning urdfdom/exportdecl.h is deprecated. Please use urdfdom/exportdecl.hpp instead. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| #pragma message("warning: urdfdom/exportdecl.h is deprecated. Please use urdfdom/exportdecl.hpp instead.") | |
| #else | |
| #warning urdfdom/exportdecl.h is deprecated. Please use urdfdom/exportdecl.hpp instead. | |
| #pragma message("warning: urdf_parser/exportdecl.h is deprecated. Please use urdf_parser/exportdecl.hpp instead.") | |
| #else | |
| #warning urdf_parser/exportdecl.h is deprecated. Please use urdf_parser/exportdecl.hpp instead. |
Comment on lines
+43
to
+45
| #pragma message("warning: urdfdom/urdf_parser.h is deprecated. Please use urdfdom/urdf_parser.hpp instead.") | ||
| #else | ||
| #warning urdfdom/urdf_parser.h is deprecated. Please use urdfdom/urdf_parser.hpp instead. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| #pragma message("warning: urdfdom/urdf_parser.h is deprecated. Please use urdfdom/urdf_parser.hpp instead.") | |
| #else | |
| #warning urdfdom/urdf_parser.h is deprecated. Please use urdfdom/urdf_parser.hpp instead. | |
| #pragma message("warning: urdf_parser/urdf_parser.h is deprecated. Please use urdf_parser/urdf_parser.hpp instead.") | |
| #else | |
| #warning urdf_parser/urdf_parser.h is deprecated. Please use urdf_parser/urdf_parser.hpp instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion over #230 (comment), I've moved the headers from .h to .hpp