Skip to content

Add pre-commit hooks and code quality baseline - #25

Merged
pdettori merged 1 commit into
mainfrom
orchestrate/precommit
Jun 30, 2026
Merged

pdettori merged 1 commit into
mainfrom
orchestrate/precommit

Conversation

@pdettori

Copy link
Copy Markdown
Member

Summary

Phase 3 of repo orchestration — establishes the code quality baseline that validates all subsequent PRs.

  • Pre-commit hooks (.pre-commit-config.yaml):
    • prettier — TS, JSON, YAML, Markdown formatting
    • shellcheck — lint 11 shell scripts in deploy/knative/
    • hadolint — Dockerfile best practices
    • gitleaks — secret detection
    • Standard hooks: trailing-whitespace, end-of-file-fixer, check-yaml, check-merge-conflict
  • Prettier config (.prettierrc, .prettierignore) — consistent formatting rules
  • Makefilelint, fmt, test, typecheck targets
  • CLAUDE.md — repo overview, dev setup, conventions
  • .claude/settings.json — Claude Code auto-approve permissions

Usage

pre-commit install          # install hooks locally
make lint                   # run all pre-commit hooks
make fmt                    # auto-format with prettier

Test plan

  • pre-commit run --all-files passes (may report formatting fixups on first run)
  • make typecheck passes (requires pi-fork built)
  • make test passes with Redis running
  • Verify shellcheck catches issues in deploy/ scripts
  • Verify gitleaks doesn't false-positive on test fixtures

Assisted-By: Claude Code

- .pre-commit-config.yaml with prettier, shellcheck, hadolint, gitleaks
- .prettierrc for consistent TS/JSON/YAML formatting
- Makefile with lint, fmt, test, typecheck targets
- CLAUDE.md with dev setup and repo conventions
- .claude/settings.json for Claude Code permissions

Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Paolo Dettori <paolo.dettori@example.com>
@pdettori
pdettori merged commit 09dd4c0 into main Jun 30, 2026
2 checks passed
@pdettori
pdettori deleted the orchestrate/precommit branch June 30, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant