Pull OCP sandbox image from GHCR instead of in-cluster build - #52
Merged
Merged
Conversation
Post-merge follow-up to P0' (#51). Now that build.yaml republishes ghcr.io/kagenti/serverless-harness-sandbox (with the ripgrep fix) on every push to main, the OCP overlay can pull it directly — symmetric with the harness image — instead of building it in-cluster. This is the "Option B" simplification flagged in the P0' design spec (§4 follow-up note). - overlays/ocp/patch-sandbox.yaml: JSON6902 image -> GHCR pullspec. - setup-ocp.sh: drop the in-cluster BuildConfig / start-build section and the --skip-sandbox-build flag; default SANDBOX_IMAGE to the GHCR image; keep --sandbox-image as a pull override (symmetric with --image); render_overlay sed now matches the GHCR sandbox string. Section banners renumbered. - README-ocp.md: sandbox row, Options, and Image delivery updated. Verified on live OCP 4.20.8: setup-ocp.sh end-to-end (no build step), sandbox-0 runs the GHCR image non-root (65532) with ripgrep 14.1.0 on a durable RWO PVC, and LEAF_LIVE_SMOKE=1 leaf-smoke.sh passes 10/10 via the Route. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <paolo.dettori@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge follow-up to P0′ (#51), executing the Option B simplification flagged in the P0′ design spec (
docs/specs/2026-07-02-p0prime-ocp-fs-free-deployment-design.md§4 follow-up note).Now that
build.yamlrepublishesghcr.io/kagenti/serverless-harness-sandbox(with the ripgrep fix) on every push tomain, the OCP overlay pulls it directly — symmetric with the harness image — instead of building it in-cluster. This drops the BuildConfig/start-build path entirely.Changes
overlays/ocp/patch-sandbox.yaml— JSON6902 image →ghcr.io/kagenti/serverless-harness-sandbox:latest.setup-ocp.sh— remove the in-cluster BuildConfig /start-buildsection (old §3) and the--skip-sandbox-buildflag +SKIP_SANDBOX_BUILDvar; defaultSANDBOX_IMAGEto the GHCR image; keep--sandbox-imageas a pull override (symmetric with--image);render_overlaysed now matches the GHCR sandbox string; section banners renumbered.README-ocp.md— sandbox row, Options block, and "Image delivery" section updated.Unchanged: durable Sandbox CR PVC, non-root 65532/fsGroup, agent-sandbox controller install,
.status.selectorpoll.Verification (live OCP 4.20.8)
Gate first confirmed the republished GHCR sandbox image is pullable and contains
rg(ripgrep 14.1.0).Then, on a swept-clean namespace:
setup-ocp.shend-to-end — no build step, sandbox Ready, ksvc Ready.sandbox-0runsghcr.io/kagenti/serverless-harness-sandbox:latest, non-root (65532/65532),rg/bash/findpresent, on a freshly-bound durable RWOgp3-csiPVC.LEAF_LIVE_SMOKE=1 leaf-smoke.shvia the Route → 10 passed, 0 failed (incl. repo-seeding into the sandbox, scale-out to 3 pods, kill/resume→verdict, scale-to-zero).Follow-up
P2 (#46 — shared sandbox pool / N:M routing / RWX on the sandbox tier) is the next step and needs its own brainstorm + spec.
Assisted-By: Claude Code