-
Notifications
You must be signed in to change notification settings - Fork 7
[WIP] Different radius per point #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 22 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
c51d430
Changing TrackManager and PointCanvas to accomodate for having a diff…
TeunHuijben 508f9af
changed default datURL to point to a public dataset with size informa…
TeunHuijben e89db62
resolved bug when assigning this.points.material.size
TeunHuijben 0067de8
changed default dataset upon loading
TeunHuijben 6393e39
minor changes to pass tests
TeunHuijben 3eeb120
changed default dataset
TeunHuijben d71afc4
fixed typo
TeunHuijben 744cd5a
removed clutter
TeunHuijben c361d6b
changed rendering to have depth-ordering correct
TeunHuijben b87d8cc
removedunused imports
TeunHuijben bdaca6f
fixed bug, now each point actually has different size
TeunHuijben a6b4484
formatting changes
TeunHuijben dd93a07
changes according to lint syntax suggestions
TeunHuijben dd9a193
centered points around origin of fov
TeunHuijben 98ca77e
added alphaTest to FragmentShader
TeunHuijben 1818403
finetuned bloomPass for esthetics
TeunHuijben c0f3b62
highlight selected cells over time, based on branch 'fix-selection-st…
TeunHuijben cba39eb
changes size of points to reflect reality
TeunHuijben 66c95db
steps towards loading datasets with/without point size information
TeunHuijben 02102d6
make dataloading compatible with each point having 3 or 4 values, dep…
TeunHuijben d3e644f
fixed bug where selected cells lost pink color when brightness was ch…
TeunHuijben d1ed4b6
lint fixes
TeunHuijben 1a836aa
PointCanvas/updateSelectedPointIndices is memoized, in a way that sel…
TeunHuijben 3c0f334
highlight all selected cells, not only the ones that are selected in …
TeunHuijben 52e6c72
Merge branch 'main' into radius-from-data
TeunHuijben 48f1591
merged this PR with main to get config functionality
TeunHuijben 2a04cf5
fixed cacheKey going to infinity
TeunHuijben b0d41fc
lint fixes
TeunHuijben 3f6fd6a
added .zattrs to points field that indicates whether 3/4 values (w/wo…
TeunHuijben 8af485b
renamed conversion script
TeunHuijben 485b0d7
resolved issue where disabled button gave error when using tooltip
TeunHuijben 25132a8
added point size as param in config, if radius not provided in zarr
TeunHuijben d9c84f3
finetuning
TeunHuijben 8a7fa57
removes saopass
TeunHuijben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could get pretty slow with a lot tracks selected. My idea in #96 (comment) was to basically memoize this function. I think the cache can also be computed/updated when adding tracks instead of when the timepoint changes.
The tradeoff is more memory, of course. I guess it should be tested but I don't think it's that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ahsley, that is good point. I made a bit of a mess by including elements from #96 (@andy-sweet) in this branch without fully merging with that PR. The reason was that #96 diverged from main a lot earlier than this branch, which made merging difficult.
I have now updated
updateSelectedPointIndicesin the next commit by using memoization. I create a map that relates a CacheKeys to theselectedPointIndicesvector. The body of this function is only evaluated the first time this combination of curTime and tracks is requested. Any future request, the vector is taken from the cache. The full cache is removed as soon as the user selects more/other cells, to prevent the cache from becoming too big.Your suggestion of precomputing the cache every time tracks are added might be cumbersome in the case of many timepoints, but we could consider this.
The dataset here is too small to experience a speed-up, but if should be faster. Was this the idea you had in mind? Let me know if anything can be improved.