feat(geyser): filter block accounts by pubkey or owner#757
Open
Efcolipt wants to merge 2 commits into
Open
Conversation
Contributor
|
hey, thanks for the pr, it looks very minimal, taking a look |
Contributor
|
@Efcolipt could you sign your commit please |
There was a problem hiding this comment.
Pull request overview
Adds owner-based matching to the Blocks stream account filtering so that updated accounts can be selected when either the account pubkey or the account owner matches blocks.account_include.
Changes:
- Extend
FilterBlocksaccount selection to matchaccount.ownerin addition toaccount.pubkey.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
973
to
975
| .filter_map(|account| { | ||
| if inner.matches_account(&account.pubkey) { | ||
| if inner.matches_account(&account.pubkey) || inner.matches_account(&account.owner) { | ||
| Some(Arc::clone(account)) |
| .iter() | ||
| .filter_map(|account| { | ||
| if inner.matches_account(&account.pubkey) { | ||
| if inner.matches_account(&account.pubkey) || inner.matches_account(&account.owner) { |
Efcolipt
force-pushed
the
master
branch
2 times, most recently
from
June 7, 2026 20:54
e76a6ea to
fed9be2
Compare
Author
|
@leafaar Signed |
Contributor
|
Could you add unit test for this please. |
Contributor
|
agree ^^ |
Author
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.