refactor str-404: extract replay policy from AutoReconnect, fix dedup invariants#811
Open
Ozodimgba wants to merge 4 commits into
Open
refactor str-404: extract replay policy from AutoReconnect, fix dedup invariants#811Ozodimgba wants to merge 4 commits into
Ozodimgba wants to merge 4 commits into
Conversation
WilfredAlmeida
approved these changes
Jul 9, 2026
WilfredAlmeida
requested changes
Jul 9, 2026
WilfredAlmeida
left a comment
WilfredAlmeida
left a comment
Contributor
There was a problem hiding this comment.
CI tests are failing
Contributor
|
since you are working on autoreconnect this might be a good PR to see if we can add more docs on the values, based on this issue, please verify: #812 |
leafaar
approved these changes
Jul 9, 2026
leafaar
left a comment
leafaar
left a comment
Contributor
There was a problem hiding this comment.
looks good, good job! please fix CI and see if you could add more docs on the auto reconnect feature as comments in the code, see if it makes sense tho, thanks!
Contributor
Author
|
yeah, the CI testa re due to me breaking napi, once @WilfredAlmeida updates to my changes i will add the docs. thank you @leafaar |
…lient (#818) * refactor: accomodate reconnection options changes from rust client Signed-off-by: Wilfred Almeida <wilfred@wilfredalmeida.com> * refactor: update examples Signed-off-by: Wilfred Almeida <wilfred@wilfredalmeida.com> * fix(ci): update crossbeam-epoch to resolve RUSTSEC-2026-0204 and remove stale RUSTSEC-2026-0009 ignore (time crate already patched) --------- Signed-off-by: Wilfred Almeida <wilfred@wilfredalmeida.com> Co-authored-by: Ozodimgba <75076112+Ozodimgba@users.noreply.github.com>
Ozodimgba
force-pushed
the
refactor/reconnect
branch
2 times, most recently
from
July 12, 2026 11:59
a52e95b to
6dbfb4f
Compare
Ozodimgba
force-pushed
the
refactor/reconnect
branch
from
July 12, 2026 12:06
6dbfb4f to
c53f1c6
Compare
WilfredAlmeida
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoReconnect conflated reconnection and replay policy, overloaded max_retries==0 as an on/off switch, duplicated backoff across AutoReconnect and TonicGrpcConnector, and DedupState accepted slot_retention=0 which silently disabled dedup.
Breaking: ReconnectConfig gained replay_policy field, GeyserGrpcBuilder reconnect_config is Option, TonicGrpcConnector::new and AutoReconnect::new signatures changed, DedupState::with_slot_retention panics on 0, prune no longer pub so NAPI bindings need update.