Shell completion: use space for all options#2647
Open
Userfrom1995 wants to merge 1 commit intorpm-software-management:mainfrom
Open
Shell completion: use space for all options#2647Userfrom1995 wants to merge 1 commit intorpm-software-management:mainfrom
Userfrom1995 wants to merge 1 commit intorpm-software-management:mainfrom
Conversation
Conan-Kudo
approved these changes
Mar 12, 2026
Userfrom1995
force-pushed
the
autocomplete
branch
from
b1d1969 to
14f74bc
Compare
kontura
reviewed
Mar 17, 2026
| if (add_description) { | ||
| std::string extended_name = name; | ||
| if (opt->get_has_value()) { | ||
| extended_name += '='; |
Contributor
There was a problem hiding this comment.
If we no longer complete the = perhaps it shouldn't also be shown in the description/help? So that it matches with the form the user will use.
Member
There was a problem hiding this comment.
It's still supposed to be valid and supported. This is just changing the style of export for the tab completion.
Shell completion now uses a space for long options that require an argument instead of '='. Space is now used for both long and short options, regardless of whether they require an argument. Fixes: rpm-software-management#2609 Assisted-by: Claude Sonnet 4.6
Userfrom1995
force-pushed
the
autocomplete
branch
from
14f74bc to
7d08e41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell completion now uses a space for long options that require an argument instead of '='.
Space is now used for both long and short options, regardless of whether they require an argument.
Fixes: #2609