Fix typos and non-standard variable names found by codespell#2652
Fix typos and non-standard variable names found by codespell#2652crawfordxx wants to merge 1 commit intorpm-software-management:mainfrom
Conversation
jrohel
left a comment
jrohel
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have one request, see the comments.
libdnf5/repo/repo_downloader.cpp
Outdated
| char buf[4096]; | ||
| int readed; | ||
| while ((readed = static_cast<int>(repomd.readsome(buf, sizeof(buf)))) > 0) { | ||
| int n; |
There was a problem hiding this comment.
Yes, readed is grammatically incorrect, but it is more descriptive than n. Could you please use a more specific name? Elsewhere in this PR (in utils.cpp), you are replacing readed with n_read. Please do the same here. It will make the PR more consistent, and n_read is more specific than n.
There was a problem hiding this comment.
Thank you for the feedback! I've updated the PR in the latest commit (f903559) to use n_read in repo_downloader.cpp instead of n, making it consistent with the naming in utils.cpp. Sorry for the initial inconsistency.
|
Thanks for the review. I've renamed |
|
Hi @jrohel, the variable has been renamed to |
- intereseted -> interested (repomanage_plugin) - prefering -> preferring (reposync_plugin) - occured -> occurred (vendor_change_manager) - wihtout -> without (transaction_sr) - succeded -> succeeded (rotating_file_logger) - occurence -> occurrence (history service) - overriden -> overridden (session) - readed/readed_type -> n_read/item_type (utils, repo_downloader, config_parser) - realy -> really (module_sack_impl)
2 participants
Fix spelling mistakes in comments and rename non-standard variable names
found by codespell:
Typos in comments:
intereseted→interested(repomanage_plugin/repomanage.cpp)prefering→preferring(reposync_plugin/reposync.cpp)occured→occurred(libdnf5/solv/vendor_change_manager.cpp)wihtout→without(libdnf5/transaction/transaction_sr.cpp)succeded→succeeded(libdnf5/logger/rotating_file_logger.cpp)occurence→occurrence(dnf5daemon-server/services/history/history.cpp)overriden→overridden(dnf5daemon-server/session.cpp)realy→really(libdnf5/module/module_sack_impl.hpp)Non-standard variable names (past tense of "read" is "read", not "readed"):
readed→n_read(libdnf5/utils/fs/utils.cpp)readed→n(libdnf5/repo/repo_downloader.cpp)readed_type→item_type(libdnf5/conf/config_parser.cpp)