Run only once the validate_filters per call - #1370
Merged
Merged
Conversation
danigm
force-pushed
the
check-validate-filteers
branch
from
July 22, 2025 08:11
88608e4 to
ecc94e2
Compare
When the cli tool is called with "-i" option in combination with a list of spec/rpm files it runs the validate_installed_packages and also the validate_files. These methods check the list of packages to lint to just run post check function and validate used filters in rpmlintrc. This patch makes sure to do not call the post check and validation twice, checking if there are also "files" during the validate_installed_packages. That way the is_last will be only true in the latter call inside validate_files. Fix #1368
danigm
force-pushed
the
check-validate-filteers
branch
from
July 22, 2025 08:17
ecc94e2 to
2edd59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the cli tool is called with "-i" option in combination with a list of spec/rpm files it runs the validate_installed_packages and also the validate_files. These methods check the list of packages to lint to just run post check function and validate used filters in rpmlintrc.
This patch makes sure to do not call the post check and validation twice, checking if there are also "files" during the validate_installed_packages. That way the is_last will be only true in the latter call inside validate_files.
Fix #1368