Use list comprehensions

rpmlint/checks/AbstractCheck.py

@@ -50,9 +50,7 @@ def check_binary(self, pkg):
             # start with the biggest files first
             filenames = sorted(filenames, key=lambda x: pkg.files[x].size, reverse=True)
             with concurrent.futures.ThreadPoolExecutor() as executor:
-                futures = []
-                for filename in filenames:
-                    futures.append(executor.submit(self.check_file, pkg, filename))
+                futures = [executor.submit(self.check_file, pkg, filename) for filename in filenames]
                 concurrent.futures.wait(futures)
                 for future in futures:
                     err = future.exception()

rpmlint/pkg.py

@@ -745,18 +745,14 @@ def get_core_reqs(self):
 def get_installed_pkgs(name):
     """Get list of installed package objects by name."""
 
-    pkgs = []
     ts = rpm.TransactionSet()
     if re.search(r'[?*]|\[.+\]', name):
         mi = ts.dbMatch()
         mi.pattern('name', rpm.RPMMIRE_GLOB, name)
     else:
         mi = ts.dbMatch('name', name)
 
-    for hdr in mi:
-        pkgs.append(InstalledPkg(name, hdr))
-
-    return pkgs
+    return [InstalledPkg(name, hdr) for hdr in mi]
 
 
 # Class to provide an API to an installed package

test/test_lint.py

@@ -385,10 +385,7 @@ def test_run_full_specs(capsys, packages, configs):
 @pytest.mark.no_cover
 def test_run_full_directory(capsys, packages):
     assert packages.is_dir()
-    file_list = []
-    for item in packages.iterdir():
-        if item.is_file():
-            file_list.append(item)
+    file_list = [item for item in packages.iterdir() if item.is_file()]
     number_of_pkgs = len(file_list)
     additional_options = {
         'rpmfile': [packages],