Simplify AbstractPkg._gather_aux to resolve consider-using-enumerate - #1383
Merged
danigm merged 1 commit intoAug 21, 2025
Merged
Conversation
vil02
force-pushed
the
resolve_consider-using-enumerate
branch
from
August 20, 2025 21:03
029c232 to
0b193d2
Compare
vil02
commented
Aug 20, 2025
| prereq.append((name, flags[loop] & (~PREREQ_FLAG), evr)) | ||
| names = header[nametag] | ||
| flags = header[flagstag] | ||
| for version, name_bytes, flag in zip(versions, names, flags): |
Contributor
Author
There was a problem hiding this comment.
Usually I would use:
Suggested change
| for version, name_bytes, flag in zip(versions, names, flags): | |
| for version, name_bytes, flag in zip(versions, names, flags, strict=True): |
This is available starting from python 3.10 (cf. PEP618) and this project claims to work for any python starting from 3.8:
Line 33 in 7b89025
vil02
marked this pull request as ready for review
August 20, 2025 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main reason for this PR is to resolve
consider-using-enumerate / C0200. But I also decided to reduce the scope ofnamesandflags.