Skip to content

Remove has_primary_key? #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yahonda merged 1 commit into from
May 5, 2026
Merged

Remove has_primary_key? #2695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,10 +914,6 @@ def pk_and_sequence_for(table_name, owner = nil, desc_table_name = nil) # :nodoc
end
end

def has_primary_key?(table_name, owner = nil, desc_table_name = nil) # :nodoc:
primary_keys(table_name).any?
end

def primary_keys(table_name) # :nodoc:
(_owner, desc_table_name) = resolve_data_source_name(table_name)

Expand Down
4 changes: 0 additions & 4 deletions spec/active_record/connection_adapters/oracle_enhanced/composite_primary_key_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@
schema_define { drop_table :test_no_pks, if_exists: true }
end

it "has_primary_key? returns true for a composite-PK table" do
expect(@conn.has_primary_key?("uber_barcodes")).to be true
end

it "pk_and_sequence_for returns nil for a composite-PK table" do
expect(@conn.pk_and_sequence_for("uber_barcodes")).to be_nil
end
Expand Down