Cover insert_fixture for CPK + CLOB#2699
Closed
yahonda wants to merge 1 commit into
Closed
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the spec case originally listed as test #4 under the umbrella
issue #2694:
The case was deferred when the umbrella PR landed because the
insert_fixtureLOB write was independently broken withORA-01002: fetch out of sequence(#2696). That bug was fixed in#2698 with a transaction wrap. Both fixes are now on master, so the
CPK + CLOB
insert_fixturepath is exercisable end-to-end.Spec
A single
itadded to the existingCLOB / BLOB columnsdescribeblock in
composite_primary_key_spec.rb, reusing thecpk_docs/CpkDocscaffolding that #2697 already set up. No production codechanges.
Test plan
bundle exec rubocopbundle exec rspec spec/active_record/connection_adapters/oracle_enhanced/composite_primary_key_spec.rb(43/43)ORACLE_ENHANCED_PREPARED_STATEMENTS_FALSE=1 bundle exec rspec spec/active_record/connection_adapters/oracle_enhanced/composite_primary_key_spec.rb(43/43)