Skip to content

Update async_show_form parameter name#43

Merged
rsnodgrass merged 1 commit into
rsnodgrass:masterfrom
nkm8:master
Jan 22, 2026
Merged

Update async_show_form parameter name#43
rsnodgrass merged 1 commit into
rsnodgrass:masterfrom
nkm8:master

Conversation

@nkm8

@nkm8 nkm8 commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

@mesa-dot-dev

mesa-dot-dev Bot commented Jan 22, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Updated a parameter name in async_show_form to resolve a configuration flow error.

What changed?

The parameter name within the async_show_form method in the custom component's configuration flow was updated. This change addresses a reported configuration flow error and aligns with the Home Assistant core API as referenced.

Description generated by Mesa. Update settings

@mesa-dot-dev mesa-dot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 881b3c1...ac4fc6d

Analysis

  1. CRITICAL: Missing minimum Home Assistant version requirement in manifest.json. The integration will break on versions prior to 2026.1.2 due to the renamed API parameter, leading to runtime errors during config flow.

  2. No backward compatibility provisions - the changes will cause failures on older Home Assistant versions without proper version constraints.

  3. The parameter rename from 'data_description' to 'description_placeholders' affects 5 instances in config_flow.py, but manifest.json must be updated to prevent installation on incompatible systems.

  4. The changes represent a hard dependency on Home Assistant 2026.1.2+ that isn't properly enforced in the integration's manifest.

Tip

Help

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

0 files reviewed | 0 comments | Edit Agent SettingsRead Docs

@rsnodgrass rsnodgrass merged commit e7ee020 into rsnodgrass:master Jan 22, 2026
3 checks passed
@rsnodgrass

Copy link
Copy Markdown
Owner

Thank you @nkm8 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants