Update async_show_form parameter name#43
Conversation
Mesa DescriptionTL;DRUpdated a parameter name in What changed?The parameter name within the Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Performed full review of 881b3c1...ac4fc6d
Analysis
-
CRITICAL: Missing minimum Home Assistant version requirement in manifest.json. The integration will break on versions prior to 2026.1.2 due to the renamed API parameter, leading to runtime errors during config flow.
-
No backward compatibility provisions - the changes will cause failures on older Home Assistant versions without proper version constraints.
-
The parameter rename from 'data_description' to 'description_placeholders' affects 5 instances in config_flow.py, but manifest.json must be updated to prevent installation on incompatible systems.
-
The changes represent a hard dependency on Home Assistant 2026.1.2+ that isn't properly enforced in the integration's manifest.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
0 files reviewed | 0 comments | Edit Agent Settings • Read Docs
|
Thank you @nkm8 !! |
Reference: https://github.com/home-assistant/core/blob/2026.1.2/homeassistant/config_entries.py#L3383
Fixes config flow error mentioned here: https://community.home-assistant.io/t/custom-component-pool-math-sensors-for-pool-chemicals-and-operations/435126/74