Skip to content

⭐ add(css_varriables): Add variables for bar height and color#219

Merged
rstacruz merged 3 commits into
rstacruz:rstacruz-2020-04-04from
anselal:rstacruz-2020-04-04
Apr 19, 2020
Merged

⭐ add(css_varriables): Add variables for bar height and color#219
rstacruz merged 3 commits into
rstacruz:rstacruz-2020-04-04from
anselal:rstacruz-2020-04-04

Conversation

@anselal

@anselal anselal commented Apr 4, 2020

Copy link
Copy Markdown

I added 2 variables, and formatted the css file

@rstacruz

Copy link
Copy Markdown
Owner

Thanks - let me roll this in with the next version on #218.

I'd prefer the variable names to be prefixed (eg, --nprogress-color) so it plays well with other libraries. It'd also be great if there are non-variable fallbacks for the benefit of legacy browsers. I'm going to implement them over at #218.

Thanks for your contribution!

@rstacruz rstacruz merged commit 7b3d99a into rstacruz:rstacruz-2020-04-04 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants