feat: Add charging constraint to LorraineConstraints#37
Merged
Conversation
rteyssandier
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for a new
requireChargingconstraint to tasks, ensuring they can be configured to run only when the device is charging. The change is implemented across the codebase, including the data model, Android and iOS platform logic, database schema, and documentation. It also introduces the necessary logic to detect charging state on iOS and integrates this new constraint into the constraint-checking pipeline.Constraint System Enhancements:
requireChargingproperty toLorraineConstraints, updated the DSL (LorraineConstraintsDefinition) to support it, and ensured conversions between domain and entity models include this new field. [1] [2]requireChargingto WorkManager'sConstraints.iOS Platform Support:
ChargingCheckfor iOS, including an observer for battery charging state changes, and integrated it into the iOS constraint checks. [1] [2] [3]Database and Schema Updates:
require_chargingcolumn to theConstraintEntityand updated the Room database schema to version 4, including an auto-migration and updated schema JSON. [1] [2] [3] [4]Documentation:
README.mdto mention the newrequireChargingconstraint option.