Skip to content

Fix #1071#1386

Open
PicoJr wants to merge 1 commit intortk-ai:developfrom
PicoJr:fix-1071
Open

Fix #1071#1386
PicoJr wants to merge 1 commit intortk-ai:developfrom
PicoJr:fix-1071

Conversation

@PicoJr
Copy link
Copy Markdown

@PicoJr PicoJr commented Apr 18, 2026

Summary

Test plan

  • Manual testing: rtk <command> output inspected
rtk on  fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0 
❯ git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579  -

rtk on  fix-1071 is 📦 v0.34.3 via 🦀 v1.92.0 
❯ ./target/debug/rtk git show ca7fbeb:test.bin | md5sum
3df17d08f5e181ff83982d9334a58579  -

AI Use disclosure:

  • I used AI to analyze the code and write the fix
  • I reviewed the code and tested the fix manually
  • I also used AI to do additional code review
  • This PR was written manually without the use of AI

I ran cargo fmt --all && cargo clippy --all-targets && cargo test on my commit

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 18, 2026

CLA assistant check
All committers have signed the CLA.

@pszymkowiak pszymkowiak added bug Something isn't working effort-small Quelques heures, 1 fichier filter-quality Filter produces incorrect/truncated signal labels Apr 18, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟢 Risk low

Summary

Fixes issue #1071 where rtk git show <rev>:<path> produced incorrect filtered content for binary blobs. The fix passes binary blob shows directly through to git instead of capturing and printing the output, preserving binary data integrity. The issue of rtk git show <rev> (without colon) for binary blobs remains unresolved.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #1071


Analyzed automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-small Quelques heures, 1 fichier filter-quality Filter produces incorrect/truncated signal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants