Skip to content

Replace with std::string_view for C++17#221

Open
gabyx wants to merge 8 commits intorttrorg:masterfrom
gabyx:feature/remove-string-view
Open

Replace with std::string_view for C++17#221
gabyx wants to merge 8 commits intorttrorg:masterfrom
gabyx:feature/remove-string-view

Conversation

@gabyx
Copy link
Copy Markdown
Contributor

@gabyx gabyx commented Jan 26, 2019

No description provided.

@gabyx
Copy link
Copy Markdown
Contributor Author

gabyx commented Jan 27, 2019

unknown warning group '-Wself-assign-overloaded', ignored
I needed to disable this warning in the test: need to turn that on for clang greater then a specific version...
for clang 7.0 it does not work.

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 27, 2019

Coverage Status

Coverage decreased (-0.03%) to 92.254% when pulling d4f31cd on gabyx:feature/remove-string-view into b3a131c on rttrorg:master.

Determine minimum cxx standard for library.
@gabyx
Copy link
Copy Markdown
Contributor Author

gabyx commented Jan 27, 2019

I included a cmake options USE_LATEST_STD which make the library if MAX_CXX_VERSION is >= 17 using std::string_view which adjusts the minimum version to 17.

@mapron
Copy link
Copy Markdown

mapron commented Jul 4, 2020

Oh, here ia the answer why RTTR uses own string_view. Any progress on this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants