fix: propagate custom block and middle tags into <script> and <style> modes - #132
Open
dnspfio wants to merge 1 commit into
Open
fix: propagate custom block and middle tags into <script> and <style> modes#132dnspfio wants to merge 1 commit into
dnspfio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Propagate extra_blocks and extra_middle_tags from the parent mode into the DjCSS/DjJS modes spawned for <style>/<script>.
Remove the resets in DjJS.init so the propagated config survives.
This makes template tags inside <script>/<style> classified identically to how they're classified in HTML/text.
Tests
Added a regression case to tests/suite/js.html: a custom block + middle family inside <script>, plus a native {% if %}/{% else %}/{% endif %} control.
Fixed tests/generate_tokens.py, which wasn't passing extra_middle_tags (it was out of sync with the test suite).