fix: load bundler/setup before attestation patch to prevent default gem conflict#34
Open
thekuwayama wants to merge 2 commits into
Open
fix: load bundler/setup before attestation patch to prevent default gem conflict#34thekuwayama wants to merge 2 commits into
thekuwayama wants to merge 2 commits into
Conversation
Author
|
I have confirmed this PR the following: |
…ndler/setup -rbundler/setup activates all gems in the Gemfile, but requires them to be installed locally first. Without bundle install, Bundler::GemNotFound is raised. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1a84d77 to
32a4d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Hi!
resolve: #28
This PR modifies that Bundler activates gems with Gemfile at first. If a default gem is listed as a dependency in your Gemfile, activation conflicts will no longer occur.
Problem
RUBYOPT loads rubygems-attestation-patch.rb before Bundler has activated the gems specified in the Gemfile. The file contains
require "rubygems/commands/push_command"which activates the default openssl of ruby-version.And Bundler tries to activate the openssl version specified in the Gemfile, a conflict occurs.
Solution
I prepend
-rbundler/setupto RUBYOPT.Bundler activates the gems specified in the Gemfile, including openssl, before rubygems-attestation-patch.rb is loaded, resolving the version conflict.