feat: Add glob_file_match option#6341
Open
BhasherBEL wants to merge 1 commit intorunatlantis:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new per-project glob_file_match configuration option to control which files must exist in a matched directory for expandProjectGlobs to include it (defaulting to ["*.tf"]).
Changes:
- Introduces
glob_file_matchin raw project config and validates its patterns. - Updates glob expansion filtering to look for any matching filename patterns (instead of only
.tf). - Adds unit/integration tests covering parsing, validation, and glob expansion behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
server/core/config/raw/project.go |
Adds GlobFileMatch field and validation for glob_file_match. |
server/core/config/raw/project_test.go |
Adds tests for YAML unmarshalling and validation error cases. |
server/core/config/parser_validator.go |
Updates glob expansion to filter directories by matching filenames (default *.tf). |
server/core/config/parser_validator_test.go |
Adds integration test ensuring glob expansion respects glob_file_match and the default behavior. |
0515425 to
69d41b1
Compare
Signed-off-by: bdubois <bdubois@openanalytics.eu>
69d41b1 to
980d8f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
glob_file_matchparameter toprojectto customize folders discovered byexpandProjectGlobs(default to["*.tf"]if not defined).Example:
why
expandProjectGlobsto match with folders that doesn't contains.tffilestests
["terragrunt.hcl"])["*.tf", "terragrunt.hcl"])references