fix: support RDATE for events with explicit future dates - #2
Merged
Conversation
An event may have DTSTART/DTEND in the past but RDATE entries listing explicit future occurrences. Previously such events were silently dropped because only DTEND was checked. When an RDATE line is found, parse each comma-separated date value. If any date falls within [now, max], keep the event - mirroring the existing RRULE behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An event can have
DTSTART/DTENDin the past but still list explicit future occurrences viaRDATE. Previously these events were silently dropped because onlyDTENDwas checked:This PR adds
RDATEhandling that mirrors the existingRRULEbehaviour: each comma-separated date is parsed, and if any falls within[now, max]the event is kept.