fix: use only start date for RDATE VALUE=PERIOD comparisons - #4
Merged
Conversation
Owner
|
This fix is released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing
RDATE;VALUE=PERIOD(formatted asstart/end), the filter was comparing the entire raw string - including the/endpart - against themaxlimit. This could cause the filter to incorrectly drop a valid event because the/endpart causes the comparison to return the wrong result.This is certainly an edge case, but still annoying if you're affected by it.
The Fix:
To check if an event falls into our time window, we only need its start date. The filter now strips everything after the
/and compares the start date only.