Add Advanced Configuration Options Inspired by pino.js (Structured Logging, Custom Levels, Transports)#4
Conversation
|
@dr-orlovsky please review |
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
Thank you very much for the excellent work! I am quite happy with it; have only two minor comments.
PS Sorry for the late review; was on a conference last week and didn't have a chance to look properly.
| #[repr(u8)] | ||
| #[derive(Clone, PartialEq, Eq, Debug)] | ||
| pub enum LogLevel { | ||
| /// Do not log anything. Corresponds to zero verbosity flags. |
There was a problem hiding this comment.
Why are we removing doc comments here?
There was a problem hiding this comment.
this was not intended, please it will be added back in the next commit
| .help("Increase verbosity level (e.g., -vvv for Info)"), | ||
| ) | ||
| .arg( | ||
| Arg::new("json") |
There was a problem hiding this comment.
Here and below: since this is a library, its clients may use names json and other in their own command-line arguments. Also, it is not clear why these names are related to logs.
I propose to add prefix log- to all these elements we introduce here (except verbose).
There was a problem hiding this comment.
other prefix was also added too, the reason is to format the log response base on the prefix passed, like child_logger, json etc
|
@dr-orlovsky can the rustup version be increased? some sub-pkg are failing on building in toolchain |
|
Sure, you can bump MSRV |
|
@dr-orlovsky i increased the rust version for the lib, because some transitive dependency are breaking. Please look into the review |
|
@dr-orlovsky review |
|
@dr-orlovsky this is waiting for your review |
|
Hi and sorry for the long delay. I took off from FOSS and GitHub due to a very negative experience I had. Now kinda back |
|
I understand, me too. |
|
Also what's next for this library, would love to hear? I think I don't have your mail, communication would be faster |
|
Are you on Telegram? Also the e-mail is dr at orlovsky ch. |
|
Yes am on telegram. My username is @iamgabrielsoft. My email is also: iamgabrielsoft@gmail.com Yes am okay accepting to be a maintainer. |
|
Please give me your telegram username so I can add you |
2 participants
This PR is tied to issue #3. Take a look for more information