Skip to content

Swap to associated trait bounds where viable#13

Merged
ryankurte merged 1 commit intomasterfrom
fix/assoc-type-bounds
Nov 1, 2021
Merged

Swap to associated trait bounds where viable#13
ryankurte merged 1 commit intomasterfrom
fix/assoc-type-bounds

Conversation

@ryankurte
Copy link
Copy Markdown
Member

  • add RadioState and ReceiveInfo associated trait bounds
  • move receive info from mutable argument to returned value using this
  • update blocking, nonblocking, mock to match
  • apply formatting

relates to #12, any opinions @henrikssn?

@henrikssn
Copy link
Copy Markdown
Member

The change LGTM, is the formatting simply what you get using cargo fmt? In that case, we might want to add a github action that verifies all code is correctly formatted.

I patched this branch into my code base and it all worked fine.

Move info from argument to returned value using this.

Co-authored-by: Rick van der Wal <rick@tweedegolf.com>
@ryankurte ryankurte force-pushed the fix/assoc-type-bounds branch from d4ef65f to f7aa1fa Compare November 1, 2021 18:54
@ryankurte ryankurte merged commit 69ffd3a into master Nov 1, 2021
@ryankurte
Copy link
Copy Markdown
Member Author

The change LGTM, is the formatting simply what you get using cargo fmt? In that case, we might want to add a github action that verifies all code is correctly formatted.

yep, and this is probably a good idea

@henrikssn
Copy link
Copy Markdown
Member

The change LGTM, is the formatting simply what you get using cargo fmt? In that case, we might want to add a github action that verifies all code is correctly formatted.

yep, and this is probably a good idea

Done in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants