Add support for batching NfNetlink messages - #45
Merged
Conversation
cathay4t
reviewed
Aug 12, 2026
cathay4t
left a comment
Member
There was a problem hiding this comment.
The changes to netlink-proto are forcing other rust-netlink crates to bump their API version and other external users might need to change their working code.
Can we somehow create new API instead changing API?
Contributor
Author
|
Can you further elaborate on your concern?
|
cathay4t
approved these changes
Aug 13, 2026
Member
My bad. The |
cathay4t
enabled auto-merge (rebase)
August 13, 2026 01:05
auto-merge was automatically disabled
August 13, 2026 01:12
Head branch was pushed to by a user without write access
Toorero
force-pushed
the
feature/nfnetlink_batch
branch
from
August 13, 2026 01:12
081e631 to
d420291
Compare
Contributor
Author
|
Pipeline (rustfmt, minimal supported Rust version) fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR should resolve #43.
It introduces a new
ConnectionHandle::request_batchmethod that supports sending multiple messages per request (and datagram by extension).Example Usage
mod_set_entry_proto.rs