Do not panic in NetlinkPayload::Overrun - #50
Merged
Conversation
When an NLMSG_OVERRUN response arrives matching that request
the forward_responses() panics on unimplemented!()
The kernel code never do this. But the kernel document said:
NLMSG_OVERRUN - socket buffer has overflown, not used to date
Hence it might be possible in the future, do decided to do so.
This patch removes the `unimplemented!()` so the Overrun message is
forwarded to the connection handle; the application must resync its
state upon receiving.
Signed-off-by: Gris Ge <cnfourt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an NLMSG_OVERRUN response arrives matching that request
the forward_responses() panics on unimplemented!()
The kernel code never do this. But the kernel document said:
Hence it might be possible in the future, do decided to do so.
This patch removes the
unimplemented!()so the Overrun message isforwarded to the connection handle; the application must resync its
state upon receiving.