Skip to content

change email from fge@redhat.com to cnfourt@gmail.com - #6

Merged
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:change_email
May 14, 2026
Merged

change email from fge@redhat.com to cnfourt@gmail.com#6
cathay4t merged 1 commit into
rust-netlink:mainfrom
cathay4t:change_email

Conversation

@cathay4t

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Gris Ge <cnfourt@gmail.com>
@cathay4t
cathay4t merged commit f470a77 into rust-netlink:main May 14, 2026
3 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the author's email and refactors internal imports to reference netlink_packet_wireguard directly. However, the removal of public re-exports in src/lib.rs constitutes a significant breaking change that forces downstream users to add netlink_packet_wireguard as a direct dependency. It is recommended to preserve these re-exports unless a major version release is intended.

I am having trouble creating individual review comments. Click here to see my feedback.

src/lib.rs (77-83)

high

Removing these re-exports is a significant breaking change that is not mentioned in the pull request title.

These re-exports allow users to use nl-wireguard without needing to add netlink-packet-wireguard as a direct dependency. Since types like WireguardMessage and WireguardCmd are part of the public API (e.g., in WireguardHandle::request), this change forces users to manage an additional dependency. Unless this decoupling is intentional and planned for a major version release, these re-exports should be preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant