change email from fge@redhat.com to cnfourt@gmail.com - #6
Conversation
Signed-off-by: Gris Ge <cnfourt@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request updates the author's email and refactors internal imports to reference netlink_packet_wireguard directly. However, the removal of public re-exports in src/lib.rs constitutes a significant breaking change that forces downstream users to add netlink_packet_wireguard as a direct dependency. It is recommended to preserve these re-exports unless a major version release is intended.
I am having trouble creating individual review comments. Click here to see my feedback.
src/lib.rs (77-83)
Removing these re-exports is a significant breaking change that is not mentioned in the pull request title.
These re-exports allow users to use nl-wireguard without needing to add netlink-packet-wireguard as a direct dependency. Since types like WireguardMessage and WireguardCmd are part of the public API (e.g., in WireguardHandle::request), this change forces users to manage an additional dependency. Unless this decoupling is intentional and planned for a major version release, these re-exports should be preserved.
No description provided.