Wayland: Implement pointer gesture hold by Murmele · Pull Request #4549 · rust-windowing/winit

Murmele · 2026-03-27T08:22:47Z

Tested on all platforms changed
Added an entry to the changelog module if knowledge of this change could be valuable to users
Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
Created or updated an example program if it would help users understand this functionality

…pad touches Description: Required to stop kinetic scrolling animations

Description: previously we got wl_display#1: error 1: invalid method 3 (since 1 < 3), object zwp_pointer_gestures_v1#21

Reason: This is usefull when using kinetic animations after the TouchPhase ended and the touchpad was touched again but no movement was executed. In this case the animation shall be stopped

winit/src/changelog/v0.31.md

winit-core/src/event.rs

Murmele

We can send it also for multiple fingers

winit-wayland/src/seat/pointer/pointer_gesture.rs

winit-core/src/event.rs

winit-wayland/src/seat/pointer/pointer_gesture.rs

Reason: Because it can be handled like Started

kchibisov · 2026-04-04T12:15:23Z

winit-wayland/src/seat/pointer/pointer_gesture.rs

+        // The chance of only one of these events being necessary is extremely small,
+        // so it is easier to just send all
+        state.events_sink.push_window_event(
+            WindowEvent::MouseWheel {


Can we not use MouseWheel for that? Adding HoldGesture should be better, since it's not that the user should pause scrolling. Alternatively, we can cancel MouseWheel, but I'm not sure it's good.

Do you mean Holdgesture as own event?

The usecase is when you scroll (pinch, rotate, ...) and release the touchpad the animation of the scroll is still ongoing due to some inertia.
When you touch the touchpad again you don't get a wheel event unless you are moving the fingers a bit.
But you get this hold event. Which shall stop the animation by sending a new start and cancel

Yes, I was suggesting to make it into separate event, so UI toolkits can handle it specially.

Because Ended doesn't mean that scrolling should be stopped, it just says taht sequence ended, but inertia won't stop.

As alternative, we can use MouseWheel { Cancel }, when hold gesture starts, but I don't see why such scrolling wouldn't be possible with just Touch and in such case the separate HoldGesture event probably makes sense?

Thanks I changed it to have an explicit Event for it

Reason: GestureHold was not considered

kchibisov

@madsmtm , do we have something like that on macOS/ios?

kchibisov · 2026-04-08T15:41:57Z

winit-core/src/event.rs

 #[derive(Debug, Hash, PartialEq, Eq, Clone, Copy)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub enum TouchPhase {
+    /// Moving the fingers started or when the touchpad gets touched with more than 2 fingers


There's no connection between fingers and the phase.

You can describe usual behavior, like for example, but we can not guarantee anything.

kchibisov · 2026-04-08T15:43:00Z

winit-core/src/event.rs

 pub enum TouchPhase {
+    /// Moving the fingers started or when the touchpad gets touched with more than 2 fingers
    Started,
+    /// Moving of the fingers is ongoing


it's not moving per-se, it's just the touch contant point changed, without e.g. lifting finger.

kchibisov · 2026-04-08T15:44:13Z

winit-core/src/event.rs

    Moved,
+    /// The fingers left the touchscreen or the touchpad
    Ended,
    Cancelled,


If you started documenting, should document this one for sure, since actually important, as in, it should cancel the event in flight if any and clear state that generated that event.

kchibisov · 2026-04-08T15:44:56Z

winit-core/src/event.rs

    Started,
+    /// Moving of the fingers is ongoing
    Moved,
+    /// The fingers left the touchscreen or the touchpad


should use for example more, we can not guarantee anything.

kchibisov · 2026-04-08T15:46:42Z

winit-core/src/event.rs

+    /// Two or more fingers touching / releasing the touchpad / touchscreen without any movement
+    HoldGesture { device_id: Option<DeviceId>, phase: TouchPhase },


You should document what user expected to do and then give example when the event may happen.

kchibisov · 2026-04-08T15:48:15Z

winit/src/changelog/unreleased.md


 - Updated `windows-sys` to `v0.61`.
 - On older macOS versions (tested up to 12.7.6), applications now receive mouse movement events for unfocused windows, matching the behavior on other platforms.
+- On wayland touchpad hold events are implemented.


it's not changed, it should be in Added and you should explain in terms of global API changes, saying that API is implemented on XYZ(Wayland), you can probably find examples in older changelogs.

Murmele added 3 commits March 27, 2026 09:17

initial add of the ZwpPointerGestureHoldV1 to be able to detect touch…

b8cf77b

…pad touches Description: Required to stop kinetic scrolling animations

ZwpPointerGestureHoldV1 is from version 3 on available

f1062ce

Description: previously we got wl_display#1: error 1: invalid method 3 (since 1 < 3), object zwp_pointer_gestures_v1#21

Implement TouchPhase::Hold

aa74d5b

Reason: This is usefull when using kinetic animations after the TouchPhase ended and the touchpad was touched again but no movement was executed. In this case the animation shall be stopped

Murmele requested a review from kchibisov as a code owner March 27, 2026 08:22

Murmele force-pushed the pointer_gesture_hold branch from 089600a to 78f1e72 Compare March 27, 2026 08:42

kchibisov requested changes Mar 27, 2026

View reviewed changes

winit/src/changelog/v0.31.md Outdated Show resolved Hide resolved

winit-core/src/event.rs Outdated Show resolved Hide resolved

add changelog and remove not needed variable

83821c4

Murmele force-pushed the pointer_gesture_hold branch from 54831f7 to 83821c4 Compare March 27, 2026 14:24

Murmele added 2 commits March 27, 2026 15:27

fix typo

30845db

no need to update wayland-protocols-plasma

b79bc78

Murmele marked this pull request as draft March 27, 2026 15:07

Murmele commented Mar 30, 2026

View reviewed changes

winit-wayland/src/seat/pointer/pointer_gesture.rs Outdated Show resolved Hide resolved

Can be send also when more than two fingers are set

d4c8168

Murmele marked this pull request as ready for review March 30, 2026 14:57

Murmele requested a review from kchibisov March 30, 2026 14:57

kchibisov requested changes Mar 30, 2026

View reviewed changes

winit-core/src/event.rs Outdated Show resolved Hide resolved

winit-wayland/src/seat/pointer/pointer_gesture.rs Outdated Show resolved Hide resolved

replace Hold TouchPhase with Started

96b6bc6

Reason: Because it can be handled like Started

kchibisov requested changes Apr 4, 2026

View reviewed changes

add explicit HoldGesture event instead of sending every gesture event

44a1409

Murmele force-pushed the pointer_gesture_hold branch from ac8aab7 to 44a1409 Compare April 7, 2026 06:48

Murmele added 2 commits April 7, 2026 13:47

fix clippy

3ad6e70

Fix compilation of the examples

0ed371f

Reason: GestureHold was not considered

kchibisov requested changes Apr 8, 2026

View reviewed changes

		/// Two or more fingers touching / releasing the touchpad / touchscreen without any movement
		HoldGesture { device_id: Option<DeviceId>, phase: TouchPhase },

Conversation

Murmele commented Mar 27, 2026

Uh oh!

Uh oh!

Uh oh!

Murmele left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kchibisov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants