Skip to content

feat(option): allow scope violation close/alarm#565

Open
fufesou wants to merge 1 commit into
rustdesk:mainfrom
fufesou:feat/option-allow-scope-violation
Open

feat(option): allow scope violation close/alarm#565
fufesou wants to merge 1 commit into
rustdesk:mainfrom
fufesou:feat/option-allow-scope-violation

Conversation

@fufesou

@fufesou fufesou commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Add an option to close the session and send an audit alert message about scope violations.

Summary by CodeRabbit

  • New Features
    • Added two new configuration options for handling scope-violation behavior: one for closing and one for alarm handling.
    • Included these options in the standard settings list so they are recognized alongside other supported settings.

Signed-off-by: fufesou <linlong1266@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a0aaa26-8531-474a-8dbe-4e137a5c1ece

📥 Commits

Reviewing files that changed from the base of the PR and between a920d00 and d27a338.

📒 Files selected for processing (1)
  • src/config.rs

📝 Walkthrough

Walkthrough

Two new public string constants for scope-violation configuration keys (close and alarm) are added to src/config.rs, and both keys are appended to the existing KEYS_SETTINGS allowlist array.

Changes

Scope Violation Configuration Keys

Layer / File(s) Summary
Add scope-violation option constants and registration
src/config.rs
Adds OPTION_ALLOW_SCOPE_VIOLATION_CLOSE and OPTION_ALLOW_SCOPE_VIOLATION_ALARM public constants and includes them in the KEYS_SETTINGS allowlist array.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: enhancement, config

Suggested reviewers: rustdesk-maintainers

🐰 Two tiny keys hop into view,
"close" and "alarm" now know what to do,
Nestled snug in the settings array,
A carrot-sized change, brightening the day.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the new scope-violation close/alarm options added in this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant