feat(hal): implement I2C instance#12
Merged
Merged
Conversation
NanaHigh
force-pushed
the
feat/hal
branch
4 times, most recently
from
43ed6e2 to
11e58c6
Compare
luojia65
approved these changes
Jan 10, 2026
luojia65
left a comment
luojia65
left a comment
Member
There was a problem hiding this comment.
LGTM with small improvements that can be applied.
| @@ -0,0 +1,5 @@ | |||
| //! I2C pad. | |||
|
|
|||
| pub trait I2CPad<const I: u8> {} | |||
Member
There was a problem hiding this comment.
Suggested change
| pub trait I2CPad<const I: u8> {} | |
| pub trait I2cPad<const I: u8> {} |
luojia65
reviewed
Jan 10, 2026
| let mut uart0 = p.uart0.new_blocking( | ||
| tx, | ||
| rx, | ||
| UartConfig { |
Member
There was a problem hiding this comment.
Can we make UartConfig::default being 115200 8N1?
- Add new example `pbp-hello-world`. - Fix code and doc issues. Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
luojia65
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pbp-i2c-master.Tested on kunlunpi board v1.1
