fix: crates.io publish-blocking manifest gaps (pointcloud license, nvsim-server version req) - #1492
Merged
Merged
Conversation
…sim-server version req) wifi-densepose-pointcloud's Cargo.toml had no license/authors/repository fields at all (crates.io rejects a publish with "missing or empty metadata fields: license") -- added the standard authors.workspace/license.workspace/repository.workspace trio every other crate in this workspace already uses. nvsim-server's path dependency on nvsim had no version requirement (crates.io rejects "all dependencies must have a version requirement specified when publishing") -- pinned to nvsim = "0.3.1", the version just published. Found while publishing both crates for the first time; both now publish cleanly (verified via cargo publish --dry-run before and after).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wifi-densepose-pointcloud's Cargo.toml had nolicense/authors/repositoryat all — crates.io rejects publish with "missing or empty metadata fields: license". Added the standard.workspace = truetrio every other crate here uses.nvsim-server's path dependency onnvsimhad no version requirement — crates.io rejects "all dependencies must have a version requirement specified when publishing". Pinned tonvsim = "0.3.1".Found and fixed while publishing both crates to crates.io for the first time (part of a broader "publish outstanding crates" pass). Both now
cargo publish --dry-runclean;wifi-densepose-pointcloud v0.1.0is already live on crates.io with this fix applied.Test plan
cargo publish -p wifi-densepose-pointcloud --dry-run— passes (was failing before)cargo publish -p nvsim-server --dry-run— passes, correctly resolvesnvsim v0.3.1from crates.io