Skip to content

added error message for parameter bug - #41

Open
JackTemaki wants to merge 1 commit into
rwth-i6:masterfrom
JackTemaki:rwth_master
Open

added error message for parameter bug#41
JackTemaki wants to merge 1 commit into
rwth-i6:masterfrom
JackTemaki:rwth_master

Conversation

@JackTemaki

Copy link
Copy Markdown
Contributor

I had a strange bug, where opening the pickle file would result in the whole config to be loaded again, resulting conflicting emtpy jobs. It took some time until I could find a wrong parameter as cause (it was a wrong class added to a dict which was part of a correct class passed as parameter, the inputs are unfortunately quite complicated sometimes).

@critias

critias commented Jun 29, 2020

Copy link
Copy Markdown
Contributor

I'm not sure if I understand the problem correctly. Something similar like this failed in your case:

class Foo(Job):
  ...

class Bar(Job):
  ...

test = Bar({'test': Foo()})
dump = pickle.dumps(test)
test_loaded = pickle.loads(dump)

Correct? The bugfix looks more like treating the symptoms and not the cause, but I need to understand the cause better.

P.S.: Sorry for the late response, I was on vacation.

@JackTemaki

JackTemaki commented Jun 29, 2020

Copy link
Copy Markdown
Contributor Author

So the issue was that during pickle.load, the whole Sisyphus config (starting from config/__init__py) was loaded again, which lead to errors. This must have been the case because some dependency was included in the pickle. Unfortunately I corrected everything, so I am not sure if I can produce this error again.

@curufinwe
curufinwe requested review from curufinwe and michelwi May 17, 2023 07:16
@curufinwe

Copy link
Copy Markdown
Collaborator

Shall we merge @michelwi ? I see no problem adding the code, even if it's not relevant anymore.

@michelwi

Copy link
Copy Markdown
Contributor

Could we check for a more specific exception or reraise the original exception together with the explanation. Just so if any other error occured the user is not confused.

@JackTemaki

Copy link
Copy Markdown
Contributor Author

From my memory I think this was a 'job' as no attribute '_sis_alias_prefixes', and one can explicitly catch for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants