workaround for pickle problem - #74
Open
albertz wants to merge 1 commit into
Open
Conversation
JackTemaki
approved these changes
Feb 22, 2022
JackTemaki
left a comment
Contributor
There was a problem hiding this comment.
The vars should never be empty if everything is normal, so this fix is okay for me.
Contributor
|
Looking at your fix my guess is that there is some circular dependency and your fix now creates a second job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the strange error:
When running a job called
OldToNewTranscriptions, which (indirectly only) depends on some output ofBeamSearchJob.Full error: https://gist.github.com/albertz/cb04e53879d43734e9f3fb62b4e09da1
Job code: https://gist.github.com/albertz/8429f7ad06bf32832b7c6ff227598982
The error occurred during unpickling. While debugging, I noticed that it would go into the
if sis_id in created_jobscode branch and it had an empty object (_sis_initwas never called). So extending the check toif sis_id in created_jobs and vars(created_jobs[sis_id])fixed the problem for me.I have not fully unterstand the real issue here and I'm not sure this is the best fix. But anyway.