if @zk is not connected redis-failover will sit there in an infinite loo...#48
Open
tobowers wants to merge 2 commits into
Open
if @zk is not connected redis-failover will sit there in an infinite loo...#48tobowers wants to merge 2 commits into
tobowers wants to merge 2 commits into
Conversation
…loop rather than trying to open the connection
Owner
|
Thanks for submitting this patch. You normally would control closing the ZK On Thu, Jan 17, 2013 at 11:56 AM, Topper Bowers notifications@github.qkg1.topwrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...p rather than trying to open the connection
This should fix #47 but there should be a better way?