Skip to content

if @zk is not connected redis-failover will sit there in an infinite loo...#48

Open
tobowers wants to merge 2 commits into
ryanlecompte:masterfrom
Amicus:topper/add_fetch_nodes_not_connected_rescue
Open

if @zk is not connected redis-failover will sit there in an infinite loo...#48
tobowers wants to merge 2 commits into
ryanlecompte:masterfrom
Amicus:topper/add_fetch_nodes_not_connected_rescue

Conversation

@tobowers

Copy link
Copy Markdown

...p rather than trying to open the connection

This should fix #47 but there should be a better way?

@ryanlecompte

Copy link
Copy Markdown
Owner

Thanks for submitting this patch. You normally would control closing the ZK
instance via a RedisFailover::Client instance. I will need to think about
your patch some more, since I don't want to introduce any new side effects.

On Thu, Jan 17, 2013 at 11:56 AM, Topper Bowers notifications@github.qkg1.topwrote:

...p rather than trying to open the connection

This should fix #47https://github.com/ryanlecompte/redis_failover/issues/47but there should be a better way?

You can merge this Pull Request by running

git pull https://github.com/Amicus/redis_failover topper/add_fetch_nodes_not_connected_rescue

Or view, comment on, or merge it at:

#48
Commit Summary

  • if @zk is not connected redis-failover will sit there in an infinite
    loop rather than trying to open the connection

File Changes

  • M lib/redis_failover/client.rb (4)

Patch Links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passing in a zk and having it close before redis-failover can trigger an infinite loop

2 participants