Skip to content

Connection handling improvements v2#73

Closed
arohter wants to merge 1 commit into
ryanlecompte:masterfrom
fanhattan:conn_handling_v2_nofork
Closed

Connection handling improvements v2#73
arohter wants to merge 1 commit into
ryanlecompte:masterfrom
fanhattan:conn_handling_v2_nofork

Conversation

@arohter

@arohter arohter commented Mar 17, 2014

Copy link
Copy Markdown
Contributor

More robust zk client error handling: support progressively more severe retry logic.
Automatic fork and InheritedError handling:
Lazy reconnects reduce zookeeper and redis server load.
Reduces surface for kernel mutex deadlocks in forking env.
Trace connection debug logging.

This is redo of #66

@arohter

arohter commented Mar 17, 2014

Copy link
Copy Markdown
Contributor Author

FYI the use of the zk fork hook ( https://github.com/fanhattan/redis_failover/compare/conn_handling_v2_nofork...conn_handling_v2_forkhook ) still causes immediate deadlocks in our env, despite running latest versions of zk/zookeeper.

@eric

eric commented Mar 17, 2014

Copy link
Copy Markdown
Collaborator

Are you able to get a ruby thread dump of all threads in one of these deadlocks?

On Mon, Mar 17, 2014 at 12:52 AM, arohter notifications@github.com
wrote:

FYI the use of the zk fork hook ( https://github.com/fanhattan/redis_failover/compare/conn_handling_v2_nofork...conn_handling_v2_forkhook ) still causes immediate deadlocks in our env, despite running latest versions of zk/zookeeper.

Reply to this email directly or view it on GitHub:
#73 (comment)

@arohter

arohter commented Oct 14, 2014

Copy link
Copy Markdown
Contributor Author

Closing this PR as obsolete.
We've been unable to fix the zk deadlock issue, and have since moved to using https://github.com/coreos/etcd as the redis_failover backend in production. We've also improved the election logic and fixed various edge cases/failures that we've run into in our high-load use. New PR coming soon!

@arohter arohter closed this Oct 14, 2014
@arohter arohter deleted the conn_handling_v2_nofork branch October 14, 2014 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants