Fix: Corrupted DNG Exports due to Tile and Strip Metadata Conflict#30
Open
Leif-US wants to merge 1 commit intorymuelle:mainfrom
Open
Fix: Corrupted DNG Exports due to Tile and Strip Metadata Conflict#30Leif-US wants to merge 1 commit intorymuelle:mainfrom
Leif-US wants to merge 1 commit intorymuelle:mainfrom
Conversation
This commit resolves an issue where DNG files generated by RawRefinery could not be opened or appeared corrupted in various RAW converters (e.g., RawTherapee, ART, darktable) or image editors (e.g., Affinity Photo). The root cause was a structural conflict in the DNG metadata: RawRefinery explicitly set 'TileWidth' and 'TileLength' tags, while the underlying 'pidng' library (in updated versions) expects and uses a 'Strip'-based image data layout. This inconsistency led DNG readers to fail in locating the actual image data. The fix involves commenting out the 'TileWidth' and 'TileLength' tag assignments in 'dng_utils.py' to align RawRefinery's DNG writing with 'pidng's strip-based encoding. Additionally, EXIF metadata handling was made more robust to prevent crashes from missing tags. This bug was diagnosed with AI assistance and the solution has been tested and confirmed to resolve the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit resolves an issue where DNG files generated by RawRefinery could not be opened or appeared corrupted in various RAW converters (e.g., RawTherapee, ART, darktable) or image editors (e.g., Affinity Photo).
The root cause was a structural conflict in the DNG metadata: RawRefinery explicitly set 'TileWidth' and 'TileLength' tags, while the underlying 'pidng' library (in updated versions) expects and uses a 'Strip'-based image data layout. This inconsistency led DNG readers to fail in locating the actual image data.
The fix involves commenting out the 'TileWidth' and 'TileLength' tag assignments in 'dng_utils.py' to align RawRefinery's DNG writing with 'pidng's strip-based encoding. Additionally, EXIF metadata handling was made more robust to prevent crashes from missing tags.