Add source table identifier support - #94
Merged
Merged
Conversation
sabino
force-pushed
the
feat/source-table-identifier
branch
from
June 18, 2026 02:38
53f5dad to
812a952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
identifierparsing while keeping logical source tablenamefor unique IDs, selectors, FQNs, and dependency keysidentifier/relation_name, DuckDB source catalog lookup, source freshness SQL, and source generic-test relationsValidation
zig test src/project/parse.zig --cache-dir /tmp/dxt-zig-cache-source-id --global-cache-dir /tmp/dxt-zig-global-cache-source-idzig test src/project/compiler.zig --cache-dir /tmp/dxt-zig-cache-source-id-compiler --global-cache-dir /tmp/dxt-zig-global-cache-source-id-compilerzig test src/project/manifest.zig --cache-dir /tmp/dxt-zig-cache-source-id-manifest --global-cache-dir /tmp/dxt-zig-global-cache-source-id-manifestzig test src/project/duckdb.zig --cache-dir /tmp/dxt-zig-cache-source-id-duckdb --global-cache-dir /tmp/dxt-zig-global-cache-source-id-duckdbzig test src/project/duckdb.zig --cache-dir /tmp/dxt-zig-cache-source-id-duckdb2 --global-cache-dir /tmp/dxt-zig-global-cache-source-id-duckdb2pytest -q tests/test_cli.py::test_source_identifier_compiles_physical_relation_and_preserves_logical_source_key tests/test_cli.py::test_source_identifier_drives_duckdb_catalog_and_freshness_relationspytest -q tests/test_cli.py::test_build_executes_selected_duckdb_source_column_generic_testszig fmt --check src/project/types.zig src/project/compiler.zig src/project/parse.zig src/project/manifest.zig src/project/duckdb.zigzig build --cache-dir /tmp/dxt-zig-cache-source-id-build --global-cache-dir /tmp/dxt-zig-global-cache-source-id-buildzig build test --cache-dir /tmp/dxt-zig-cache-source-id-buildtest --global-cache-dir /tmp/dxt-zig-global-cache-source-id-buildtestpython scripts/check_runtime_boundary.pypython scripts/check_public_safety.pypytest -q tests/test_cli.py(115 passed in 684.12sbefore the final source-generic-test coverage amendment; amended commit is covered by targeted local tests and green GitHub CI)git diff --check origin/main...HEADReview