Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use const string& in the Loop: This avoids unnecessary copies when iterating through the input vector.
String Key Construction: Instead of using a separate variable to create the key, we can directly construct it in a single loop. This is more straightforward and avoids potential confusion.
Reserve Space for the Result: By reserving space for the ans vector, we can reduce the number of reallocations that might occur as we push back results.
Move Semantics: When adding the grouped strings to the result, using move transfers ownership without copying, which can improve performance when dealing with larger strings.