fix: map cargo PURL to canonical ecosystem so malware is detected#744
Merged
Conversation
vet scan --purl pkg:cargo/... never queried malware analysis for the
correct ecosystem. PurlTypeToEcosystem("cargo") returned
lockfile.CargoEcosystem ("crates.io"), but GetControlTowerSpecEcosystem
switches on vet's model ecosystem constants (EcosystemCargo == "Cargo"),
so it fell through to ECOSYSTEM_UNSPECIFIED and the malware query was
sent without an ecosystem. Cargo was the only mismatch since other
osv-scanner ecosystem strings coincidentally equal vet's model constants.
Map cargo to the canonical model ecosystem, consistent with the existing
GitHub Actions / VSCode / OpenVSX entries.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
abhisek
approved these changes
Jun 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
=======================================
Coverage 12.41% 12.41%
=======================================
Files 372 372
Lines 49231 49231
=======================================
Hits 6114 6114
Misses 42632 42632
Partials 485 485 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vet scan --purl pkg:cargo/... never queried malware analysis for the correct ecosystem. PurlTypeToEcosystem("cargo") returned lockfile.CargoEcosystem ("crates.io"), but GetControlTowerSpecEcosystem switches on vet's model ecosystem constants (EcosystemCargo == "Cargo"), so it fell through to ECOSYSTEM_UNSPECIFIED and the malware query was sent without an ecosystem. Cargo was the only mismatch since other osv-scanner ecosystem strings coincidentally equal vet's model constants.
Map cargo to the canonical model ecosystem, consistent with the existing GitHub Actions / VSCode / OpenVSX entries.