feat(log): force enable command output by envvar#1252
Open
xxchan wants to merge 1 commit into
Open
Conversation
Signed-off-by: xxchan <xxchan22f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workaround #1069
Currently
--loglevel errorwill implysilent, and will hide command output.I'm not sure what's the best way to change that without breaking previous behavior, so just introduced an env var to forceabily enable command output.
Another idea is to let
--loglevelonly changescargo make's log, i.e., those collected by the logger.--silentcan keep the behavior as before. However, it becomes a separate flag, adn won't be enabled by--loglevel error.