Skip to content

fix observation vector issue #324 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omertarikbanus wants to merge 1 commit into from
Closed

fix observation vector issue #324 #325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion envpool/core/py_envpool.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,16 @@ struct ArrayToNumpyHelper {
auto capsule = py::capsule(ptr, [](void* ptr) {
delete reinterpret_cast<std::shared_ptr<char>*>(ptr);
});
return py::array(a.Shape(), reinterpret_cast<dtype*>(a.Data()), capsule);
// Calculate strides explicitly to ensure correct memory layout
std::vector<py::ssize_t> strides(a.Shape().size());
if (!strides.empty()) {
strides[strides.size() - 1] = sizeof(dtype);
for (int i = strides.size() - 2; i >= 0; --i) {
strides[i] = strides[i + 1] * a.Shape()[i + 1];
}
}
return py::array(py::dtype::of<dtype>(), a.Shape(), strides,
reinterpret_cast<dtype*>(a.Data()), capsule);
}
};

Expand Down
Loading